Conversation
Summary of ChangesHello @timon-schelling, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the project's build and execution mechanisms by introducing a new Rust-based command-line tool. This tool consolidates various Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new building crate to replace the root package.json scripts for running and building the project, which is a great simplification. However, I've found a few issues in the implementation of this new tool. The command runner can panic on empty command strings, and the argument parsing logic doesn't correctly handle all the commands mentioned in the updated documentation, specifically cargo run build and cargo run -- production. I've provided suggestions to fix these issues, along with some minor improvements for code clarity and correctness.
| impl From<&str> for Profile { | ||
| fn from(arg: &str) -> Self { | ||
| match arg { | ||
| "release" => Profile::Release, |
There was a problem hiding this comment.
The documentation was updated to use cargo run -- production, but this from implementation doesn't handle the "production" string. This will result in an error. You should also handle "production" as a Profile::Release.
| "release" => Profile::Release, | |
| "release" | "production" => Profile::Release, |
| let comand = comand.split_whitespace().collect::<Vec<_>>(); | ||
| let mut cmd = process::Command::new(comand[0]); | ||
| if comand.len() > 1 { | ||
| cmd.args(&comand[1..]); | ||
| } |
There was a problem hiding this comment.
The current implementation will panic if an empty command string is passed to run_from, because comand.split_whitespace().collect::<Vec<_>>() will be an empty vector, and comand[0] will be an out-of-bounds access. This can be handled more robustly and efficiently by using an iterator directly, which also avoids an intermediate allocation.
let mut parts = comand.split_whitespace();
let Some(program) = parts.next() else { return };
let mut cmd = process::Command::new(program);
cmd.args(parts);
tools/building/src/main.rs
Outdated
| ["build", rest @ ..] => build_desktop(rest.into()), | ||
| _ => run_desktop(rest.into()), | ||
| }, | ||
| rest => run_web(rest.into()), |
There was a problem hiding this comment.
The documentation was updated to use cargo run build, but this command is not handled here. It will fall into the rest case, which will try to parse "build" as a profile, fail, and show the usage message. You should add a case to handle the build command directly, which can default to building the web version.
["build", rest @ ..] => build_web(rest.into()),
rest => run_web(rest.into()),|
|
||
| impl From<&[&str]> for Profile { | ||
| fn from(arg: &[&str]) -> Self { | ||
| arg.first().map(|s| s.to_string()).as_deref().unwrap_or_default().into() |
There was a problem hiding this comment.
This from implementation can be simplified for better readability and to avoid an unnecessary string allocation.
| arg.first().map(|s| s.to_string()).as_deref().unwrap_or_default().into() | |
| arg.first().copied().unwrap_or("").into() |
| run_from(comand, Some("frontend")); | ||
| } | ||
|
|
||
| pub fn run_from(comand: &str, dir: Option<&str>) { |
There was a problem hiding this comment.
There's a typo in the parameter name comand. It should be command. This typo appears in several places in this file (run, run_in_frontend_dir, run_from and its body). Please correct it throughout the file for consistency and clarity.
| pub fn run_from(comand: &str, dir: Option<&str>) { | |
| pub fn run_from(command: &str, dir: Option<&str>) { |
timon-schelling
force-pushed
the
cargo-run-tool
branch
2 times, most recently
from
16fca60 to
8cb8c29
Compare
timon-schelling
force-pushed
the
cargo-run-tool
branch
from
8cb8c29 to
b7e0fac
Compare
timon-schelling
force-pushed
the
cargo-run-tool
branch
from
b7e0fac to
f0f3969
Compare
1 participant
depends on #3808